🐛 Fixed comment thread connector lines occasionally appearing doubled#28124
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
WalkthroughThis PR updates the visual styling of threaded comment reply connector lines in the comments UI component. Three connector line elements—the reply form continuation line, the replies threading line, and the left-side connector in reply layout—were changed from a fixed-width background ( Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx build @tryghost/comments-ui |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/signup-form |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/sodo-search |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/announcement-bar |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/portal |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/activitypub |
✅ Succeeded | 1s | View ↗ |
nx run @tryghost/comments-ui:test:acceptance |
✅ Succeeded | 47s | View ↗ |
nx run-many -t test:unit -p @tryghost/comments-ui |
✅ Succeeded | 17s | View ↗ |
Additional runs (5) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-05-26 13:09:02 UTC
- The vertical lines linking nested replies were rendered as 1px-wide divs filled with a background colour. At certain DPI scales and zoom levels browsers painted these 2-3px wide, which gave the appearance of two parallel lines next to the cleanly-rendered elbow connectors. - Switched the lines to use `border-l`, the same render path the elbow connectors already use, so reply, continuation and elbow lines all align on whole-pixel boundaries and render consistently.
8be01de to
044548d
Compare
044548d to
39b0277
Compare

border-l, the same render path the elbow connectors already use, so reply, continuation and elbow lines all align on whole-pixel boundaries and render consistently.