⚡ Bolt: Optimize Rust memory footprint & Cargo profile#554
Conversation
💡 What: 1. Replaced `AHashMap<String, String>` with `AHashMap<Box<str>, Box<str>>` in caching layers (fingerprint.rs & properties.rs). 2. Added `panic = "abort"` to the `[profile.release]` configuration in `Cargo.toml`. 🎯 Why: 1. `String` structs carry a capacity field, taking 24 bytes per instance on 64-bit systems. Since these are cache entries that are never mutated/resized, using `Box<str>` drops the capacity pointer and reduces overhead to 16 bytes per string. 2. The Android module is injected via Zygisk. In an embedded JNI/FFI environment, panics are effectively fatal. Building with `panic = "abort"` strips out the unwinding infrastructure. 📊 Impact: - Reduces `.so` binary size significantly by stripping unwind tables. - Reduces memory overhead for all globally cached strings by 33% per string. 🔬 Measurement: - Checked successfully using `cargo test` to ensure functional parity and safe Rust boundaries.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
YiğitProject ID: Tip Silent mode disables those chatty PR comments if you prefer peace and quiet |
1 participant
⚡ Bolt: Optimize Rust memory footprint & Cargo.toml release profile
💡 What:
AHashMap<String, String>withAHashMap<Box<str>, Box<str>>in caching layers (fingerprint.rs & properties.rs).panic = "abort"to the[profile.release]configuration inCargo.toml.🎯 Why:
Stringstructs carry a capacity field, taking 24 bytes per instance on 64-bit systems. Since these are cache entries that are never mutated/resized, usingBox<str>drops the capacity pointer and reduces overhead to 16 bytes per string.panic = "abort"strips out the unwinding infrastructure.📊 Impact:
.sobinary size significantly by stripping unwind tables.🔬 Measurement:
cargo testto ensure functional parity and safe Rust boundaries.PR created automatically by Jules for task 11672702419596065688 started by @tryigit