fix(tokenizer): Allow multi-line comments that aren't followed by a space #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace Currently the start of a multi-line comment is only parsed as such if the tokenizer is in one of the junk states; that is, if it is followed by a space or newline. Starts of multi-line comments that occur at the beginning of the source text or immediately after the end of a token are misparsed as a division punctuator followed by a multiplication punctuator. This change fixes this.
ghost
reviewed
Aug 28, 2022
MierenManz
reviewed
Dec 26, 2022
Collaborator
MierenManz
left a comment
MierenManz
left a comment
There was a problem hiding this comment.
Lgtm but I'm not the parsing expert here
aapoalas
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the start of a multi-line comment is only parsed as such if the tokenizer is in one of the junk states; that is, if it is followed by a space or newline. Starts of multi-line comments that occur at the beginning of the source text or immediately after the end of a token are misparsed as a division punctuator followed by a multiplication punctuator. This change fixes this.