Commit 81f72df
committed
fix(vanilla): re-measure canvas pointer rects on pointerenter
The rect cache added in 529ebb8 invalidated on scroll and resize, but an
element can move without either firing: content above the chart
expanding, an accordion opening, a web font loading and reflowing the
page. Any of those left stale boxes and offset hit-testing until the
next scroll. Invalidating on pointerenter starts every hover session
with a fresh measurement, bounding staleness to mid-hover layout shifts.
The new test shifts the chart with no scroll event and asserts the next
hover session hits against the moved box.
Also flattens an empty-stops gradient to 'transparent' instead of
'none' in scatter-canvas/state.ts. 'none' is not a canvas color:
assigning it to fillStyle is silently ignored, so the previous fill
color would keep painting. Defensive only -- the compiler never emits an
empty stop list.1 parent f5536d3 commit 81f72df
4 files changed
Lines changed: 31 additions & 7 deletions
File tree
- packages/vanilla/src/scatter-canvas
- __tests__
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
119 | 119 | | |
120 | 120 | | |
121 | 121 | | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
122 | 139 | | |
123 | 140 | | |
124 | 141 | | |
| |||
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
| 39 | + | |
| 40 | + | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
54 | 57 | | |
55 | 58 | | |
56 | 59 | | |
| |||
143 | 146 | | |
144 | 147 | | |
145 | 148 | | |
| 149 | + | |
146 | 150 | | |
147 | 151 | | |
148 | 152 | | |
| |||
152 | 156 | | |
153 | 157 | | |
154 | 158 | | |
| 159 | + | |
155 | 160 | | |
156 | 161 | | |
157 | 162 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
25 | 27 | | |
26 | 28 | | |
27 | 29 | | |
| |||
0 commit comments