fix: align brand watermark with source text in footer

[rileyhilliard]

Summary

• Switches brand watermark from alphabetic to hanging dominant-baseline, aligning the top edge of the watermark text with the source/byline chrome text
• Removes the manual BRAND_LARGE y-offset that was previously needed to compensate for bottom-aligned positioning
• Fixes oversized footer height when both source and watermark are present

Test plan

• Visual check on charts with both source text and watermark present
• Visual check on charts with watermark only (no source/byline)
• Verify footer height is compact and text aligns on the same top edge

Summary by CodeRabbit

• Bug Fixes
  • Improved the vertical alignment and positioning of the footer watermark text for better visual consistency.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a2d0a588-3fc5-4b9d-a676-4d13acd93aaa

📥 Commits

Reviewing files that changed from the base of the PR and between dce75cf and 9ac5426.

📒 Files selected for processing (1)

• packages/vanilla/src/renderers/brand.ts

---

📝 Walkthrough

Walkthrough

The brand watermark footer text now uses a hanging baseline with direct y-coordinate positioning instead of alphabetic baseline with an offset, improving alignment of mixed-size text elements.

Changes

Brand Watermark Positioning

Layer / File(s)	Summary
Brand watermark baseline and positioning packages/vanilla/src/renderers/brand.ts	The <text> element baseline changes from "alphabetic" to "hanging" and y-position from chromeY + BRAND_LARGE to chromeY, simplifying vertical alignment for mixed-size tspans.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through SVG lines,
With hanging baselines so fine,
No offsets needed anymore,
Just chromeY at the core—
Alignment dreams come true in time! 🐰✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/brand-footer-alignment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}