Wire up document navigation methods to use DocumentSession APIs #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complete the second phase of migrating from legacy document_data to DocumentSession by implementing all navigation methods that were stubbed out in the previous commit: - Page navigation via session_navigate_page - Link navigation via session_navigate_link - List and list item navigation via session_navigate_list/list_item - Heading navigation via session_navigate_heading (with level filtering) - Table navigation and activation via session_navigate_table - Table of contents dialog with session_document integration - Go to Page dialog updated to use session_document - Elements dialog (headings/links list) updated to use session_document - page_index, marker_count, marker_position_by_index now use DocumentSession Add ensure_toc_loaded() for lazy TOC loading and find_closest_toc_offset() to session_document struct. Update dialogs to accept session_document*. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the DocumentSession migration started in 2c040ee, restoring all navigation functionality that was temporarily disabled.
page_index,marker_count, andmarker_position_by_indexmethods that were stubbed outFixes #232