Skip to content

[chore][PLAT-1058] Add support for extraContainers to code-executor deployment#274

Merged
jthemphill merged 1 commit intomainfrom
jhemphill/helm-extra-sidecar
Apr 21, 2026
Merged

[chore][PLAT-1058] Add support for extraContainers to code-executor deployment#274
jthemphill merged 1 commit intomainfrom
jhemphill/helm-extra-sidecar

Conversation

@jthemphill
Copy link
Copy Markdown
Contributor

@jthemphill jthemphill commented Apr 20, 2026

Test to make sure that existing templates don't completely change:

# See generated templates without the change
git checkout main
mkdir -p /tmp/before
for f in charts/retool/ci/*.yaml; do
  name=$(basename "$f" .yaml)
  helm template charts/retool -f "$f" > /tmp/before/$name.yaml 2>&1
done

# See generated templates with the change
git checkout jhemphill/helm-extra-sidecar
mkdir -p /tmp/after
for f in charts/retool/ci/*.yaml; do
  name=$(basename "$f" .yaml)
  helm template charts/retool -f "$f" > /tmp/after/$name.yaml 2>&1
done

# Diff to make sure existing templates are unchanged
diff -r /tmp/before /tmp/after
Result of diff
diff -ur /tmp/before/test-install-values.yaml /tmp/after/test-install-values.yaml
--- /tmp/before/test-install-values.yaml	2026-04-20 13:28:01
+++ /tmp/after/test-install-values.yaml	2026-04-20 13:28:09
@@ -6,7 +6,7 @@
 metadata:
   name: release-name-retool
   labels:
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
 ---
 # Source: retool/charts/postgresql/templates/secrets.yaml
@@ -32,7 +32,7 @@
 metadata:
   name: release-name-retool
   labels:
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
   annotations:
     "helm.sh/resource-policy": no-upgrade-existing
@@ -167,7 +167,7 @@
 kind: Service
 metadata:
   labels:
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
   name: release-name-retool
 spec:
@@ -187,7 +187,7 @@
 metadata:
   name: release-name-retool
   labels:
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
     app.kubernetes.io/name: retool
     app.kubernetes.io/instance: release-name
@@ -202,7 +202,7 @@
     metadata:
       annotations:
       labels:
-        helm.sh/chart: retool-6.10.2
+        helm.sh/chart: retool-6.10.3
         app.kubernetes.io/managed-by: Helm
         app.kubernetes.io/name: retool
         app.kubernetes.io/instance: release-name
@@ -222,7 +222,7 @@
           - name: DEPLOYMENT_TEMPLATE_TYPE
             value: "k8s-helm"
           - name: DEPLOYMENT_TEMPLATE_VERSION
-            value: "6.10.2"
+            value: "6.10.3"
           - name: NODE_ENV
             value: production
           - name: SERVICE_TYPE
@@ -339,7 +339,7 @@
     app.kubernetes.io/name: release-name-retool-code-executor
     app.kubernetes.io/instance: release-name
     telemetry.retool.com/service-name: code-executor
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
 spec:
   replicas: 1
@@ -355,7 +355,7 @@
         app.kubernetes.io/name: release-name-retool-code-executor
         app.kubernetes.io/instance: release-name
         telemetry.retool.com/service-name: code-executor
-        helm.sh/chart: retool-6.10.2
+        helm.sh/chart: retool-6.10.3
         app.kubernetes.io/managed-by: Helm
     spec:
       serviceAccountName: release-name-retool
@@ -371,7 +371,7 @@
           - name: DEPLOYMENT_TEMPLATE_TYPE
             value: "k8s-helm"
           - name: DEPLOYMENT_TEMPLATE_VERSION
-            value: "6.10.2"
+            value: "6.10.3"
           - name: NODE_ENV
             value: production
           - name: NODE_OPTIONS
@@ -422,7 +422,7 @@
     app.kubernetes.io/name: release-name-retool-workflow-worker
     app.kubernetes.io/instance: release-name
     telemetry.retool.com/service-name: workflow-worker
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
 spec:
   replicas: 1
@@ -441,7 +441,7 @@
         app.kubernetes.io/name: release-name-retool-workflow-worker
         app.kubernetes.io/instance: release-name
         telemetry.retool.com/service-name: workflow-worker
-        helm.sh/chart: retool-6.10.2
+        helm.sh/chart: retool-6.10.3
         app.kubernetes.io/managed-by: Helm
     spec:
       serviceAccountName: release-name-retool
@@ -457,7 +457,7 @@
           - name: DEPLOYMENT_TEMPLATE_TYPE
             value: "k8s-helm"
           - name: DEPLOYMENT_TEMPLATE_VERSION
-            value: "6.10.2"
+            value: "6.10.3"
           - name: NODE_ENV
             value: production
           - name: NODE_OPTIONS
@@ -576,7 +576,7 @@
     app.kubernetes.io/name: release-name-retool-workflow-backend
     app.kubernetes.io/instance: release-name
     telemetry.retool.com/service-name: workflow-backend
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
 spec:
   replicas: 1
@@ -592,7 +592,7 @@
         app.kubernetes.io/name: release-name-retool-workflow-backend
         app.kubernetes.io/instance: release-name
         telemetry.retool.com/service-name: workflow-backend
-        helm.sh/chart: retool-6.10.2
+        helm.sh/chart: retool-6.10.3
         app.kubernetes.io/managed-by: Helm
     spec:
       serviceAccountName: release-name-retool
@@ -608,7 +608,7 @@
           - name: DEPLOYMENT_TEMPLATE_TYPE
             value: "k8s-helm"
           - name: DEPLOYMENT_TEMPLATE_VERSION
-            value: "6.10.2"
+            value: "6.10.3"
           - name: NODE_ENV
             value: production
           - name: SERVICE_TYPE
@@ -871,7 +871,7 @@
 kind: Ingress
 metadata:
   labels:
-    helm.sh/chart: retool-6.10.2
+    helm.sh/chart: retool-6.10.3
     app.kubernetes.io/managed-by: Helm
   name: release-name-retool
 spec:

@jthemphill jthemphill merged commit d496a48 into main Apr 21, 2026
12 checks passed
@jthemphill jthemphill deleted the jhemphill/helm-extra-sidecar branch April 21, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants