Skip to content

Fixup: remove references to AppVersion #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anna-yn merged 1 commit into from
Jan 19, 2022
Merged

Fixup: remove references to AppVersion #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: retool
description: A Helm chart for Kubernetes
type: application
version: 4.6.0
version: 4.6.1
maintainers:
- name: Retool Engineering
email: engineering+helm@retool.com
Expand Down
2 changes: 1 addition & 1 deletion templates/deployment_backend.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ spec:
{{- end }}
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"
image: "{{ .Values.image.repository }}:{{ required "Please set a value for .Values.image.tag" .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- bash
Expand Down
2 changes: 1 addition & 1 deletion templates/deployment_jobs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
{{- end }}
containers:
- name: {{ .Chart.Name }}
image: "{{ .Values.image.repository }}:{{ default .Chart.AppVersion .Values.image.tag }}"
image: "{{ .Values.image.repository }}:{{ required "Please set a value for .Values.image.tag" .Values.image.tag }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
args:
- bash
Expand Down
4 changes: 2 additions & 2 deletions values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ config:

image:
repository: "tryretool/backend"
# Will default to Chart AppVersion if left empty
tag: "X.Y.Z"
# You need to pick a specific tag here, this chart will not make a decision for you
tag: ""
pullPolicy: "IfNotPresent"

commandline:
Expand Down