Add escape hatch for extra manifests + support for env vars from secrets#35
Add escape hatch for extra manifests + support for env vars from secrets#35anna-yn merged 7 commits intotryretool:mainfrom
Conversation
the-nando
changed the title
| secretKeyRef: | ||
| name: {{ .secretKeyRef.name }} | ||
| key: {{ .secretKeyRef.key }} | ||
| {{- end }} |
There was a problem hiding this comment.
I typically see this handled with just a singmple toYaml:
env:
{{- toYaml .Values.application.environment | nindent 12 }}
It would be a backwards-incompatible change, but then this chart would instantly handle all the current and future complexity of env var descriptions. Not sure how the maintainers would feel about that, though. I want this feature far more than I want this feature to be perfect. :)
There was a problem hiding this comment.
yeaa I agree the single toYaml is much nicer, but we need to think more about breaking changes 😬 let's get your changes landed first!
|
We really need this for our gitops workflow too. |
anna-yn
left a comment
anna-yn
left a comment
There was a problem hiding this comment.
just 1 nit, thank you so much for the PR ❤️
|
@anna-yn it should be good to go now. If you prefer bumping only the minor version of the chart (4.6.1 -> 4.6.2) instead of releasing 4.7.0, let me know and I'll update it accordingly |
I think 4.7.0 is fine, there's something else we need to land soon, we'll just lump them into one minor release |
4 participants
Fixes #34