Skip to content

fix: add missing service account file#5

Merged
kyle-retool merged 1 commit intotryretool:mainfrom
philippeboyd:hotfix/add-missing-serviceaccount-file
Feb 10, 2021
Merged

fix: add missing service account file#5
kyle-retool merged 1 commit intotryretool:mainfrom
philippeboyd:hotfix/add-missing-serviceaccount-file

Conversation

@philippeboyd
Copy link
Copy Markdown
Contributor

also changed the create value from false to true.

@kyle-retool
Copy link
Copy Markdown
Contributor

kyle-retool commented Feb 10, 2021

Should create be renamed to enabled to mirror the other values?

@philippeboyd
Copy link
Copy Markdown
Contributor Author

No because it'll imply that a service account is optional where in Kubernetes a service account is always used. The use case is more: do you want to create a service account or use an existing one, therefore create: true|false is appropriated.

In most cases, you'll always want to create a service account specific to your application.

Other renowned helm charts do this such as Vault or Ambassador

@kyle-retool kyle-retool merged commit 67532a8 into tryretool:main Feb 10, 2021
@kyle-retool
Copy link
Copy Markdown
Contributor

Published version 4.1.1 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants