fix: add missing service account file#5
Merged
kyle-retool merged 1 commit intotryretool:mainfrom Feb 10, 2021
Merged
Conversation
kyle-retool
approved these changes
Feb 10, 2021
Contributor
|
Should |
Contributor
Author
|
No because it'll imply that a service account is optional where in Kubernetes a service account is always used. The use case is more: do you want to create a service account or use an existing one, therefore In most cases, you'll always want to create a service account specific to your application. Other renowned helm charts do this such as Vault or Ambassador |
Contributor
|
Published version 4.1.1 with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also changed the
createvalue fromfalsetotrue.