Merged
Conversation
This also makes it possible to specify a path; currently setting a
path for the ingress is broken, as it uses `{{ .path }}`, which
appears to have been copied from the default ingress template (as
created by `helm init`) without the `range` that would make that
possible.
Our specific use case is to set up Datadog monitoring with annotations on the backend pods, but not the job runners. (E.g., an HTTP probe against the job runners isn't much use.) This approach should be expanded to other things, like resources, affinity/anti-affinity, etc.
this can be used to target different ingress providers in a cluster.
Support ingressClassName
…ine-license-key add support for offline license key
Allow more than one hostname for ingress
Allow for different annotations/labels for job runners and backend pods
This reverts commit ba01e38.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.