Merged
Conversation
robert-burden
approved these changes
May 26, 2022
goodspark
reviewed
May 31, 2022
values.yaml
Outdated
| # secretKeyRef: | ||
| # name: retool-github-app-private-key | ||
| # key: private-key | ||
| # - name: NAME |
Contributor
There was a problem hiding this comment.
Nitpick:
Suggested change
| # - name: NAME | |
| # - name: POD_HOST_IP |
That's not the exact name we'd use, but it better clarifies the example I think.
Contributor
|
@lsovern can we use something more generic than |
anna-yn
approved these changes
Jun 1, 2022
Contributor
anna-yn
left a comment
anna-yn
left a comment
There was a problem hiding this comment.
agree with @goodspark 's suggestion, otherwise lgtm!
prashantmital
approved these changes
Jun 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for env variables that aren't key-value with a new variable called
extraEnvs. This will make the existingenvandenvironmentSecretsredundant, but leaving them in so as not to break existing things.