Skip to content

Fix fullnameOverride and externalSecrets.externalSecretsOperator.secretRef#59

Merged
anna-yn merged 1 commit intotryretool:mainfrom
robotpistol:values-file-fixes
Jun 7, 2022
Merged

Fix fullnameOverride and externalSecrets.externalSecretsOperator.secretRef#59
anna-yn merged 1 commit intotryretool:mainfrom
robotpistol:values-file-fixes

Conversation

@robotpistol
Copy link

@robotpistol robotpistol commented Jun 6, 2022

When implementing on-prem retool I noticed a couple of discrepancies in the values file.

  1. fullNameOverride -> fullnameOverride
  2. externalSecrets.externalSecretsOperator.secretRef is defaulted to a map but the comment above specifies it's an array. My local overrides also failed unless i corrected the values file to be a [] instead. Also the examples is an array of maps rather than a map.

@anna-yn anna-yn merged commit a903cf6 into tryretool:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants