[feat] add support for PodDisruptionBudgets for retool backend#8
Merged
[feat] add support for PodDisruptionBudgets for retool backend#8
Conversation
Closes [REQ-38](https://linear.app/retool/issue/REQ-38/add-pod-disruption-budget-in-helm-2-and-helm-3-charts) This diff allows users to specify a PodDisruptionBudget in their values file, instructing Kubernetes to protect the application \# Testing plan 1. Create a minikube cluster with two nodes: ``` $ minikube start $ minikube node add ``` 2. Install retool into the cluster, with a replica count of three: ``` $ helm upgrade --install --values values.yaml myretool . --set replicaCount=3 ``` 3. Uncomment the example in the values file, then upgrade again: ``` $ helm upgrade --values values.yaml myretool . --set replicaCount=3 ``` 4. Confirm presence of PodDisruptionBudget: ``` $ kubectl describe poddisruptionbudget myretool Name: myretool Namespace: default Max unavailable: 1 Selector: app.kubernetes.io/instance=myretool,app.kubernetes.io/name=retool Status: Allowed disruptions: 0 Current: 1 Desired: 2 Total: 3 Events: <none> ``` 5. Attempt to take down a node running two copies of `myretool`: ``` ± % kubectl drain minikube-m02 --ignore-daemonsets node/minikube-m02 cordoned WARNING: ignoring DaemonSet-managed Pods: kube-system/kindnet-zmd4g, kube-system/kube-proxy-g8mhx evicting pod default/myretool-fcdd777fc-q4hzq evicting pod default/myretool-fcdd777fc-9b45f error when evicting pods/"myretool-fcdd777fc-9b45f" -n "default" (will retry after 5s): Cannot evict pod as it would violate the pod's disruption budget. ```
asaf400
pushed a commit
to asaf400/retool-helm
that referenced
this pull request
Aug 17, 2023
* add support for mTLS with external temporal cluster * typo fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff allows users to specify a PodDisruptionBudget in their values file,
instructing Kubernetes to protect the application
Testing plan
myretool: