Fix wpmjson config side effects

[thelovekesh]

Updated wpmjson config struct to use an internal field to store default config. Also, added methods to get required default config.

[gemini-code-assist]

Summary of Changes

Hello @thelovekesh, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the wpmjson.Config structure to better handle default values and prevent side effects when modifying configuration. By centralizing default settings and introducing accessor methods, it ensures that default values are consistently applied without being inadvertently altered, leading to more predictable and stable behavior across the application.

Highlights

• Centralized Default Configuration: Default values for BinDir, ContentDir, and RuntimeStrict are now stored internally within the wpmjson.Config struct, preventing unintended modifications to shared default instances.
• Accessor Methods for Config Values: New methods (BinDir(), ContentDir(), RuntimeStrict()) have been introduced to retrieve configuration values, ensuring that default values are provided seamlessly if not explicitly set by the user.
• Simplified RuntimeStrict Type: The RuntimeStrict field in types.PackageConfig has been changed from a pointer (*bool) to a direct boolean (bool), simplifying its usage and removing the need for nil checks.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the wpm.json configuration handling to encapsulate default values, which is a positive change for maintainability. However, the current implementation introduces critical bugs. Firstly, changing RuntimeStrict from a pointer to a boolean breaks the default-true behavior. Secondly, the new getter methods fail to apply default values when a configuration is read from disk because the wpmjson.Read function doesn't initialize the configuration with defaults. My review includes specific suggestions to fix these issues.

[github-actions]

📦 wpm cli builds 📦

• darwin/amd64 - build
• darwin/arm64 - build
• linux/amd64 - build
• linux/arm/v6 - build
• linux/arm/v7 - build
• linux/arm64 - build
• linux/ppc64le - build
• linux/riscv64 - build
• linux/s390x - build
• windows/amd64 - build
• windows/arm64 - build