Skip to content

Remove package type field when auto generating the wpm.json#145

Merged
thelovekesh merged 1 commit intomainfrom
udpate/init-command
Jan 14, 2026
Merged

Remove package type field when auto generating the wpm.json#145
thelovekesh merged 1 commit intomainfrom
udpate/init-command

Conversation

@thelovekesh
Copy link
Collaborator

When running wpm init -y, we generally add type: plugin which is not correct, hence that fields will be omitted now.

@gemini-code-assist
Copy link

Summary of Changes

Hello @thelovekesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the behavior of the wpm init command, specifically addressing an issue where an incorrect type: plugin field was automatically added to the wpm.json file during non-interactive initialization. The changes ensure that the packageType field is no longer defaulted or validated in non-interactive contexts, leading to cleaner and more accurate wpm.json configurations.

Highlights

  • Non-interactive wpm init behavior: The wpm init command, when run in non-interactive mode (e.g., with -y flag or in a non-terminal environment), will no longer automatically set the packageType field to plugin in the generated wpm.json file.
  • Conditional Package Type Validation: The validation for the packageType field is now conditionally skipped when wpm init is executed in non-interactive mode, aligning with the intent to omit this field by default in such scenarios.
  • Precise type field generation: The type field will only be written to wpm.json if a valid packageType is explicitly provided, preventing the inclusion of incorrect or unwanted default values in the configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link

📦 wpm cli builds 📦

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes the automatic setting of packageType: 'plugin' when running wpm init -y. However, this change exposes an issue where the generated wpm.json file will be invalid according to wpmjson.Config.Validate(), as the type field is still treated as required during validation. This could cause other commands to fail. I've added a comment with a suggestion to address this by making the type field validation optional and adding a validation step to runNewInit for consistency.

@thelovekesh thelovekesh merged commit 3cc907e into main Jan 14, 2026
15 checks passed
@thelovekesh thelovekesh deleted the udpate/init-command branch January 14, 2026 20:53
@thelovekesh thelovekesh added the command any changes to the wpm cli command label Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

command any changes to the wpm cli command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant