-
Notifications
You must be signed in to change notification settings - Fork 2
Add install scripts #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install scripts #148
Conversation
thelovekesh
commented
Jan 16, 2026
- Add wpm cli installer scripts
- Update docker image to run wpm cli using docker
Summary of ChangesHello @thelovekesh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience for installing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces installer scripts for both Windows and Unix-like systems, and updates the Docker image. The changes are a great addition to the project. The Dockerfile improvements to use a distroless image and ENTRYPOINT are excellent for security and standard practice. The new installer scripts are well-structured, but I've identified a few areas for improvement regarding robustness, modern practices, and minor bugs. My review includes suggestions to fix a bug in the Rosetta 2 detection, improve path handling in the PowerShell script, use more modern PowerShell cmdlets, and refine the shell script's file handling and privilege usage.
70f6f66 to
6dd1212
Compare