chore: sync config files from .config-templates#3
Conversation
WalkthroughAdds cache-dependency-glob to the uv setup in the composite action, switches arduino/setup-task repo-token to github.token, refactors the uv Task command block and updates PATH to $HOME/.local/bin, bumps ruff-pre-commit to v0.12.10, ignores .output.txt, and makes a minor Taskfile formatting tweak. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
.gitignore (1)
11-12: Consider moving personal/ephemeral ignores to a global ignore.The “temp file used by Junie” entry (.output.txt) looks user-specific. If this file isn’t part of CI artifacts, consider using a developer-local global gitignore or a repo-local .gitignore.local pattern to avoid accumulating user-specific entries in the shared template.
.github/actions/setup-project/action.yml (1)
23-23: Trim trailing whitespace (yamllint trailing-spaces).There are trailing spaces on Line 23; remove them to satisfy linters.
Apply this minimal change:
- +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (5)
.github/actions/setup-project/action.yml(1 hunks).github/taskfiles/build.yml(1 hunks).gitignore(1 hunks).pre-commit-config.yaml(1 hunks)Taskfile.yml(0 hunks)
💤 Files with no reviewable changes (1)
- Taskfile.yml
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/actions/setup-project/action.yml
[error] 23-23: trailing spaces
(trailing-spaces)
🔇 Additional comments (2)
.pre-commit-config.yaml (1)
12-12: Ruff hook bump looks good.Version bump to ruff-pre-commit v0.12.10 is straightforward and should be compatible with existing args.
.github/actions/setup-project/action.yml (1)
28-29: Using github.token for repo-token is OK.arduino/setup-task documents repo-token as optional and commonly set to the GitHub-provided token; switching to ${{ github.token }} is consistent with guidance.
Reference: arduino/setup-task README on repo-token. (github.com)
| cache-dependency-glob: "**/*requirements*.txt,**/*requirements*.in,**/*constraints*.txt,**/*constraints*.in,**/pyproject.toml,**/uv.lock" | ||
|
|
There was a problem hiding this comment.
cache-dependency-glob should be newline-delimited, not comma-separated.
The action expects a single glob or a newline-delimited list. A comma-separated string will be treated as one literal pattern and won’t match the intended files, causing stale caches. Use a block scalar with one glob per line.
Apply this diff:
- cache-dependency-glob: "**/*requirements*.txt,**/*requirements*.in,**/*constraints*.txt,**/*constraints*.in,**/pyproject.toml,**/uv.lock"
+ cache-dependency-glob: |
+ **/*requirements*.txt
+ **/*requirements*.in
+ **/*constraints*.txt
+ **/*constraints*.in
+ **/pyproject.toml
+ **/uv.lockReference: setup-uv v6 docs show newline-delimited examples and defaults for this input. (github.com)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| cache-dependency-glob: "**/*requirements*.txt,**/*requirements*.in,**/*constraints*.txt,**/*constraints*.in,**/pyproject.toml,**/uv.lock" | |
| cache-dependency-glob: | | |
| **/*requirements*.txt | |
| **/*requirements*.in | |
| **/*constraints*.txt | |
| **/*constraints*.in | |
| **/pyproject.toml | |
| **/uv.lock |
🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 23-23: trailing spaces
(trailing-spaces)
🤖 Prompt for AI Agents
.github/actions/setup-project/action.yml around lines 22-23: the
cache-dependency-glob value is currently a comma-separated string which will be
treated as a single literal glob; replace it with a newline-delimited block
scalar containing one glob per line (use YAML pipe | then list each glob on its
own line, no commas) so the action receives multiple patterns correctly and
cache matching works as intended.
| - | | ||
| # install uv and uvx | ||
| curl -sSf https://astral.sh/uv/install.sh | sh > /dev/null 2>&1 || { echo "${RED}Installation failed!${RESET}" >&2; exit 1; } | ||
| export PATH="$HOME/.local/bin:$PATH" |
There was a problem hiding this comment.
🛠️ Refactor suggestion
PATH export here won’t persist to dependent tasks; uv may not be found later.
Exporting PATH inside this command block only affects this shell. Tasks like “install” and “build” run in separate shells and may fail to find uv if ~/.local/bin isn’t already on PATH in the user’s environment. Recommend setting PATH via Taskfile env so all tasks inherit it.
Apply one of the following:
Option A: Set env at the Taskfile root (outside the shown hunk):
version: '3'
env:
PATH: "{{.PATH}}:$HOME/.local/bin"
tasks:
# ...Option B: Set env per task:
tasks:
uv:
desc: Install uv and uvx
env:
PATH: "{{.PATH}}:$HOME/.local/bin"
cmds:
- |
# install uv and uvx
curl -sSf https://astral.sh/uv/install.sh | sh > /dev/null 2>&1 || { echo "${RED}Installation failed!${RESET}" >&2; exit 1; }
install:
deps: [uv]
env:
PATH: "{{.PATH}}:$HOME/.local/bin"
build:
deps: [install]
env:
PATH: "{{.PATH}}:$HOME/.local/bin"🤖 Prompt for AI Agents
In .github/taskfiles/build.yml around lines 7 to 10, exporting PATH inside the
inline shell only affects that shell so later tasks won't see ~/.local/bin; move
the PATH export into Taskfile env so all tasks inherit it. Either add an env
block at the Taskfile root setting PATH to "{{.PATH}}:$HOME/.local/bin" so every
task gets the updated PATH, or add an env block to each affected task (uv,
install, build) with PATH: "{{.PATH}}:$HOME/.local/bin"; remove the inline
export line from the command block once env is set.
1 participant
This PR updates config files from tschm/.config-templates.
Summary by CodeRabbit
Chores
Style