Skip to content

Conversation

@isaumya
Copy link
Contributor

@isaumya isaumya commented Nov 11, 2022

Here is the list of improvements that I have made:

  1. In the constants.js file I've added a new variable named bgColors which now holds all the options for the background colors. I've also used the colors variable but now it holds the text color options.
  2. In the /src/buttons/edit.js I've updated the code to call the bgColors and colors from constants and then use them inside the code to set up the background-color and color properties accordingly.
  3. I've also updated the /src/coloum/edit.js file to ensure that now it imports bgColors from constants and uses that inside the code.
  4. Executed the build command to generate the new build files.
  5. Tested the updated code and ensured that things are working properly as they should.
  6. Updated the README.md file for the wpBootstrapBlocks.button.styleOptions filter so that now it shows users how they can add both the bgColor and color properties while using the filter.
  7. I've tested the code by adding custom style options for the button and ensure everything is working properly.

Please take a look at the PR and let me when you can publish it.

…n.styleOptions hook so users can pass both the background and the text colors for the buttons
…background color options. Also added a colors variable that holds the text colors.
… to have both bgColor and color set by the user for each buttons style options.
… bgColors and also inside the code wherever the colors variables have been used, replaced that with the bgColors
@tschortsch tschortsch changed the base branch from master to improvement/better-property-names November 15, 2022 07:42
@tschortsch tschortsch self-assigned this Nov 15, 2022
@tschortsch tschortsch merged commit 60f859f into tschortsch:improvement/better-property-names Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants