This repository was archived by the owner on Aug 15, 2025. It is now read-only.
changed convertSoupToExcellonDrillCommands to use metric units#107
Merged
seveibar merged 1 commit intotscircuit:mainfrom Sep 1, 2024
Merged
changed convertSoupToExcellonDrillCommands to use metric units#107seveibar merged 1 commit intotscircuit:mainfrom
seveibar merged 1 commit intotscircuit:mainfrom
Conversation
Contributor
Author
|
|
Contributor
Author
|
also format checks are still failing |
Contributor
Author
|
|
seveibar
approved these changes
Sep 1, 2024
Contributor
|
Yes someone has to pr the fix i described to fix the format check, is an open issue |
This was referenced Sep 1, 2024
Contributor
|
@ShiboSoftwareDev fwiw we basically want everything to be in mm at the end of the day, whenever you see a number that isnt a string it should be mm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@seveibar It worked after I changed the units used in the ptr file to metric, it seems like it was receiving inches and converting them to inches again which explains the tiny drill holes.