Skip to content
This repository was archived by the owner on Aug 15, 2025. It is now read-only.

feat: add port ids#88

Merged
imrishabh18 merged 4 commits intomainfrom
feat/add-port-ids
Jul 29, 2024
Merged

feat: add port ids#88
imrishabh18 merged 4 commits intomainfrom
feat/add-port-ids

Conversation

@imrishabh18
Copy link
Copy Markdown
Member

@imrishabh18 imrishabh18 commented Jul 29, 2024

@imrishabh18 imrishabh18 requested a review from seveibar July 29, 2024 13:37
Comment thread tests/trace-builder/simple-trace-test.test.ts
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh looking at the screenshot: only the first and last point in the route should have the start_pcb_port_id, basically if the x/y is on the pcb port then the id should be defined.

@imrishabh18
Copy link
Copy Markdown
Member Author

So, only the first and last endpoint will be having start_pcb_port_id and no end_pcb_port_id, while the other will be having both, right?

@seveibar
Copy link
Copy Markdown
Contributor

No the others will have undefined. It's kind of confusing and likely to change but you should only have an idea if the x y position represents the port

@imrishabh18
Copy link
Copy Markdown
Member Author

This is what you mean't, that the first one is having it's port_id as the starting point and similarly the last one is having it's port_id as the starting point (bi-directional)

@imrishabh18 imrishabh18 requested a review from seveibar July 29, 2024 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants