Use jlcMinTolerances values for DRC defaults#136
Merged
imrishabh18 merged 6 commits intomainfrom Apr 21, 2026
Merged
Conversation
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
@tscircuit/jlcpcb-manufacturing-specstodevDependenciespinned to commitfa54ff1f9eabca1b852a0b035db907061e5c4a2finpackage.json.jlcMinTolerancesfrom@tscircuit/jlcpcb-manufacturing-specsinlib/drc-defaults.tsand use its fields as the source for DRC minimums.jlcMinTolerancesvalues and fall back to the previous numeric constants where the package does not supply a value.DEFAULT_VIA_BOARD_MARGINandEPSILONunchanged.Testing
bun run format, which completed but reported existing large-file warnings for JSON fixtures; formatting run finished (warnings only).npm install(git dependency resolved) andnpm run build, and the build completed successfully.Codex Task