Skip to content

Use jlcMinTolerances values for DRC defaults#136

Merged
imrishabh18 merged 6 commits intomainfrom
codex/add-jlcpcb-manufacturing-specs-as-devdep
Apr 21, 2026
Merged

Use jlcMinTolerances values for DRC defaults#136
imrishabh18 merged 6 commits intomainfrom
codex/add-jlcpcb-manufacturing-specs-as-devdep

Conversation

@imrishabh18
Copy link
Copy Markdown
Member

Motivation

  • Align local DRC default values with the published JLCPCB minimum manufacturing tolerances so checks use the manufacturer minimums rather than hardcoded values.

Description

  • Add @tscircuit/jlcpcb-manufacturing-specs to devDependencies pinned to commit fa54ff1f9eabca1b852a0b035db907061e5c4a2f in package.json.
  • Import jlcMinTolerances from @tscircuit/jlcpcb-manufacturing-specs in lib/drc-defaults.ts and use its fields as the source for DRC minimums.
  • Replace hardcoded defaults with expressions that prefer jlcMinTolerances values and fall back to the previous numeric constants where the package does not supply a value.
  • Preserve unrelated constants like DEFAULT_VIA_BOARD_MARGIN and EPSILON unchanged.

Testing

  • Ran bun run format, which completed but reported existing large-file warnings for JSON fixtures; formatting run finished (warnings only).
  • Performed npm install (git dependency resolved) and npm run build, and the build completed successfully.

Codex Task

@imrishabh18 imrishabh18 requested a review from seveibar April 21, 2026 23:39
@imrishabh18 imrishabh18 merged commit f4fdb28 into main Apr 21, 2026
5 checks passed
@imrishabh18 imrishabh18 deleted the codex/add-jlcpcb-manufacturing-specs-as-devdep branch April 21, 2026 23:41
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants