Use pcb_board DRC values and remove JLC specs dependency import#137
Closed
imrishabh18 wants to merge 1 commit intomainfrom
Closed
Use pcb_board DRC values and remove JLC specs dependency import#137imrishabh18 wants to merge 1 commit intomainfrom
imrishabh18 wants to merge 1 commit intomainfrom
Conversation
seveibar
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
@tscircuit/jlcpcb-manufacturing-specsand instead use DRC values embedded in thepcb_boardelement of the circuit JSON.Description
@tscircuit/jlcpcb-manufacturing-specsfromdevDependenciesand replaced dependency-backed defaults with local numeric fallbacks inlib/drc-defaults.ts.getBoardDrcValue(circuitJson, key, fallback)to read manufacturing DRC properties from thepcb_boardelement and return a typed numeric fallback when unset.minClearanceor trace widths are not explicitly provided: pad-pad usesmin_pad_to_pad_clearance, pad-trace and via-trace usemin_trace_to_pad_clearance, via spacing usesmin_via_to_via_clearance, and trace thickness falls back tomin_trace_width.min_board_edge_clearance(with fallback) for the board-edge margin.Testing
npm run buildcompleted successfully.npx biome format --writeon all touched files (succeeded) to apply formatter fixes.npm run format:checkinitially reported repository-level warnings due to large test fixtures, and formatter suggestions were applied to the modified files; formatting of touched files is now applied.Codex Task