Use insertion_direction for connector accessibility checks#141
Merged
ShiboSoftwareDev merged 2 commits intotscircuit:mainfrom Apr 24, 2026
Merged
Use insertion_direction for connector accessibility checks#141ShiboSoftwareDev merged 2 commits intotscircuit:mainfrom
ShiboSoftwareDev merged 2 commits intotscircuit:mainfrom
Conversation
seveibar
approved these changes
Apr 24, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Why did other snaps change hmm
Contributor
Author
|
because I updated tscircuit and all it's deps |
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update connector accessibility checks to use pcb_component.insertion_direction when available, with fallback to cable_insertion_center for older data. This maps side-entry directions to facing axes, skips from_above, and no longer requires cable_insertion_center to run the check.