Skip to content

Fix Dependencies#43

Merged
seveibar merged 2 commits intomainfrom
fixdeps
May 12, 2025
Merged

Fix Dependencies#43
seveibar merged 2 commits intomainfrom
fixdeps

Conversation

@seveibar
Copy link
Copy Markdown
Contributor

@seveibar seveibar commented May 12, 2025

@seveibar seveibar merged commit 00bcebb into main May 12, 2025
4 checks passed
Comment thread package.json
Comment on lines 28 to 32
"peerDependencies": {
"circuit-json": "*",
"@tscircuit/math-utils": "*",
"circuit-json-to-connectivity-map": "*",
"typescript": "^5.5.3"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that circuit-to-svg was moved from dependencies to devDependencies but wasn't added to peerDependencies like the other similar packages (@tscircuit/math-utils and circuit-json-to-connectivity-map).

For consistency with the internal library pattern being established, consider adding circuit-to-svg to the peerDependencies section with a value of *:

"peerDependencies": {
  "circuit-json": "*",
  "@tscircuit/math-utils": "*",
  "circuit-json-to-connectivity-map": "*",
  "circuit-to-svg": "*",
  "typescript": "^5.5.3"
}

This would maintain a consistent dependency pattern across all internal libraries.

Suggested change
"peerDependencies": {
"circuit-json": "*",
"@tscircuit/math-utils": "*",
"circuit-json-to-connectivity-map": "*",
"typescript": "^5.5.3"
"peerDependencies": {
"circuit-json": "*",
"@tscircuit/math-utils": "*",
"circuit-json-to-connectivity-map": "*",
"circuit-to-svg": "*",
"typescript": "^5.5.3"

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@seveibar seveibar deleted the fixdeps branch May 12, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant