Skip to content

Refactor transpile "main" path validation #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2025
Merged

Refactor transpile "main" path validation #1065

merged 1 commit into from
Nov 26, 2025

Conversation

@seveibar
Copy link
Contributor

@seveibar seveibar commented Nov 26, 2025

Summary

  • extract a shared validator to ensure package.json main points inside dist before transpiling
  • use the shared main validation for both tsci build --transpile and tsci transpile

Testing

  • bunx tsc --noEmit
  • bun test tests/cli/build/build-transpile.test.ts
  • bun test tests/cli/transpile

Codex Task

@seveibar seveibar changed the title Refactor transpile main validation Refactor transpile "main" path validation Nov 26, 2025
@seveibar seveibar merged commit 3d9484b into main Nov 26, 2025
8 checks passed
@seveibar seveibar deleted the codex/check-main-points-to-dist-in-build branch November 26, 2025 00:12
@tscircuitbot
Copy link
Contributor

tscircuitbot commented Nov 26, 2025

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seveibar @tscircuitbot