Transpilation Asset Loading Fix #1072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
commented
Nov 27, 2025
|
|
||
| expect(esmContent).toMatchInlineSnapshot(` | ||
| "import { jsx } from 'react/jsx-runtime'; | ||
| import cadModelUrl from './assets/chip-e043b555.glb'; |
Contributor
Author
There was a problem hiding this comment.
@imrishabh18 this is what I've been looking for. This is web-standard. I created the snapshot, explained how it needed to import assets, then explained to opus the issue. It quickly generated the fix
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @Ayushjhawar8 @imrishabh18 confirmed working