Handle binary package files during clone by using download endpoint #1629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tsci clonepreviously assumed file content was returned as text and failed to restore binary files.is_textflag onpackage_files/getand a separatepackage_files/downloadendpoint for binary content, so the clone flow must use those to restore files correctly.Description
package_files/getresponse type to includepackage_file_id,is_text, and nullablecontent_textand read those fields.is_textis true andcontent_textis a string, write the file withfs.writeFileSync(fullPath, contentText); otherwise callpackage_files/downloadwith thepackage_file_idand write the returnedarrayBufferas aBuffer.cli/clone/register.tsand only affect the clone file restore logic.Testing
Codex Task