Fix Subcircuit Autorouting, send externallyConnectedPointIds to autorouter (which internally handles an MSP for picking best routes)

[seveibar]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tscircuit-core-benchmarks	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 1, 2025 9:48pm

[cursor]

Bug: Unsafe Type Cast Causes External Connection Failures

The unsafe type cast of tr.route as any[] can cause a runtime error if tr.route is not iterable. Additionally, it bypasses type safety for seg.start_pcb_port_id and seg.end_pcb_port_id, leading to silent failures where the "externally connected points" feature may not correctly identify connected ports due to an assumed route structure that doesn't match the actual database schema.

lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts#L320-L324

core/lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson.ts

Lines 320 to 324 in bf5792a

	const tracePortIds = new Set<string>()
	for (const seg of tr.route as any[]) {
	if (seg.start_pcb_port_id) tracePortIds.add(seg.start_pcb_port_id)
	if (seg.end_pcb_port_id) tracePortIds.add(seg.end_pcb_port_id)
	}

Fix in Cursor

---

BugBot free trial expires on July 22, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎