Add nested packing snapshot test and support packing subgroups#1106
Merged
Add nested packing snapshot test and support packing subgroups#1106
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bugbot free trial expires on July 29, 2025
Learn more in the Cursor dashboard.
| top: Math.max(...ys), | ||
| bottom: Math.min(...ys), | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Polygon Padding Miscalculates Bounds
The getBounds function for polygon pads incorrectly calculates bounds. Unlike other pad shapes, it fails to offset the polygon points (p.x, p.y) by the pad's position (pad.x, pad.y), leading to inaccurate bounding box calculations.
seveibar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
BUN_UPDATE_SNAPSHOTS=1 bun test tests/features/pcb-pack-layout/board-pack-nested-groups.test.tsxhttps://chatgpt.com/codex/tasks/task_b_68866759857c832e9b9613c6c23a4f3d