test: add pcb snapshot for polygon smtpads with coveredWithSolderMask#1985
Open
ETwithin wants to merge 2 commits intotscircuit:mainfrom
Open
test: add pcb snapshot for polygon smtpads with coveredWithSolderMask#1985ETwithin wants to merge 2 commits intotscircuit:mainfrom
ETwithin wants to merge 2 commits intotscircuit:mainfrom
Conversation
Closes tscircuit/tscircuit#786 (partial) Adds a PCB snapshot test demonstrating that polygon-shaped smtpads correctly propagate is_covered_with_solder_mask: true in circuit-json output and render with the solder mask layer visible. The test uses a 5-pad capacitive touch slider layout (short→tall→short) matching the design from the issue.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a PCB snapshot test demonstrating that polygon-shaped smtpads correctly:
is_covered_with_solder_mask: truein circuit-json outputshowSolderMask: trueTest Details
The test uses a 5-pad capacitive touch slider layout (short → tall → short) matching the design from tscircuit/tscircuit#786:
Each pad uses
shape="polygon"withcoveredWithSolderMask={true}.Assertions
pcb_smtpadelements haveis_covered_with_solder_mask: trueshape: "polygon"andpointsarray in circuit-jsonRelated