Skip to content

Improve invalid pinLabel error message #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MustafaMulla29 merged 3 commits into from
Mar 4, 2026
+3 −3
Merged

Improve invalid pinLabel error message #1997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0bbfb4
Improve invalid pinLabel error message
MustafaMulla29 Mar 3, 2026
13a44cf
update
MustafaMulla29 Mar 3, 2026
dde207d
Merge remote-tracking branch 'origin/main' into fix/pinlabel-err
MustafaMulla29 Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/utils/filterPinLabels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function filterPinLabels(
validLabels.push(label)
} else {
invalidPinLabelsMessages.push(
`Invalid pin label: ${pin} = '${label}' - excluding from component. Please use a valid pin label.`,
`Invalid pin label: ${pin} = '${label}' - excluding from component. Pin labels can only contain letters, numbers and underscores.`,
)
}
}
Expand Down
2 changes: 1 addition & 1 deletion tests/components/normal-components/chip-invalid-pin.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ test("chip with invalid pin should be skipped", async () => {

expect(source_property_ignored_warning).toHaveLength(1)
expect(source_property_ignored_warning[0].message).toContain(
"Invalid pin label: pin3 = '//' - excluding from component. Please use a valid pin label.",
"Invalid pin label: pin3 = '//' - excluding from component. Pin labels can only contain letters, numbers and underscores.",
)

expect(circuit).toMatchSchematicSnapshot(import.meta.path)
Expand Down
2 changes: 1 addition & 1 deletion tests/repros/repro93-chip-pinlabel-leading-space.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ test("chip pinLabels should not allow leading or trailing spaces", async () => {

expect(schematic_errors).toHaveLength(1)
expect(schematic_errors[0].message).toContain(
"Invalid pin label: pin1 = 'A1 ' - excluding from component. Please use a valid pin label.",
"Invalid pin label: pin1 = 'A1 ' - excluding from component. Pin labels can only contain letters, numbers and underscores.",
)
})