Deduplicate logical ports from composite footprint copper#2132
Merged
ShiboSoftwareDev merged 3 commits intomainfrom Apr 14, 2026
Merged
Deduplicate logical ports from composite footprint copper#2132ShiboSoftwareDev merged 3 commits intomainfrom
ShiboSoftwareDev merged 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
approved these changes
Apr 14, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes composite footprints where multiple copper primitives share the same logical pin,
such as an SMT pad plus plated hole with the same portHints.
Previously, footprint port discovery returned one port per copper primitive, so repeated
pin1/pin2 hints could inflate the inferred pin count and create extra logical pins like
pin3 and pin4.
This adds a shared helper to normalize footprint portHints, merge aliases, and dedupe
ports by logical pin number for both string and JSX footprints.