Skip to content

Support rotated pill-hole-with-rect-pad plated hole#2141

Merged
techmannih merged 1 commit intotscircuit:mainfrom
techmannih:mm
Apr 15, 2026
Merged

Support rotated pill-hole-with-rect-pad plated hole#2141
techmannih merged 1 commit intotscircuit:mainfrom
techmannih:mm

Conversation

@techmannih
Copy link
Copy Markdown
Member

  • internally convert <platedhole shape="pill_hole_with_rect_pad" pcbRotation={...} /> to rotated_pill_hole_with_rect_pad, matching the existing rotated hole behavior
  • add the reverse circuit-json mapping so rotated_pill_hole_with_rect_pad imports back into PlatedHole with pcbRotation
  • keep rotated and non-rotated paths as separate explicit branches for readability
  • add a regression test and snapshot for rotated pill-hole-with-rect-pad plated holes

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Apr 15, 2026 3:53am

Request Review

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@techmannih techmannih merged commit 316509d into tscircuit:main Apr 15, 2026
11 checks passed
@techmannih techmannih deleted the mm branch April 15, 2026 04:10
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants