Emit a warning when manufacturerPartNumber is missing for the connector#2143
Merged
MustafaMulla29 merged 2 commits intomainfrom Apr 16, 2026
Merged
Emit a warning when manufacturerPartNumber is missing for the connector#2143MustafaMulla29 merged 2 commits intomainfrom
MustafaMulla29 merged 2 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
reviewed
Apr 16, 2026
| standard: props.standard, | ||
| subcircuit_id: this.getSubcircuit()?.subcircuit_id ?? undefined, | ||
| warning_type: "source_missing_manufacturer_part_number_warning", | ||
| message: `${this.getString()} has standard="${props.standard}" but no manufacturerPartNumber (mfn). Add mfn if you do not want the USB-C part to change in future.`, |
Member
There was a problem hiding this comment.
Suggested change
| message: `${this.getString()} has standard="${props.standard}" but no manufacturerPartNumber (mfn). Add mfn if you do not want the USB-C part to change in future.`, | |
| message: `${this.getString()} has standard="${props.standard}" but no manufacturerPartNumber (mfn). Add mfn if you do not want the part to change in future.`, |
Is the connector always usb-c?
Contributor
Author
There was a problem hiding this comment.
Yes currently only usbc is implemented
Contributor
Author
There was a problem hiding this comment.
Although your suggestion sounds good
seveibar
approved these changes
Apr 16, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.