Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
noConnectlist (e.g. onchip) to mark source ports as intentionally unconnected and prevent spurious missing-trace warnings.Description
db.source_port.get(...).do_not_connectis true inNormalComponent_doInitialSourceDesignRuleChecks.ts.Port._getMatchingPinAttributesto read the parent_parsedProps.noConnectarray and produce a{ doNotConnect: true }match for aliases listed there, and return an empty array when no matches are found.@tscircuit/propsdevDependency to^0.0.506and apply small test/typing cleanups inintrinsic-jsx.tsand component test fixtures.tests/components/normal-components/chip-no-connect-prop.test.tsxto verifynoConnectbehavior and adjusttests/repros/repro87-trace-overlap.test.tsxfor updated typings.Testing
bun testincludingtests/components/normal-components/chip-no-connect-prop.test.tsxandtests/repros/repro87-trace-overlap.test.tsx, and all tests passed.Codex Task