Skip to content

Honor noConnect on chips: mark source ports do_not_connect and suppress missing-trace warnings#2147

Merged
seveibar merged 1 commit intomainfrom
codex/add-support-for-noconnect-property
Apr 17, 2026
Merged

Honor noConnect on chips: mark source ports do_not_connect and suppress missing-trace warnings#2147
seveibar merged 1 commit intomainfrom
codex/add-support-for-noconnect-property

Conversation

@seveibar
Copy link
Copy Markdown
Contributor

Motivation

  • Allow a component-level noConnect list (e.g. on chip) to mark source ports as intentionally unconnected and prevent spurious missing-trace warnings.

Description

  • Skip creating a missing-trace warning if db.source_port.get(...).do_not_connect is true in NormalComponent_doInitialSourceDesignRuleChecks.ts.
  • Extend Port._getMatchingPinAttributes to read the parent _parsedProps.noConnect array and produce a { doNotConnect: true } match for aliases listed there, and return an empty array when no matches are found.
  • Bump @tscircuit/props devDependency to ^0.0.506 and apply small test/typing cleanups in intrinsic-jsx.ts and component test fixtures.
  • Add tests/components/normal-components/chip-no-connect-prop.test.tsx to verify noConnect behavior and adjust tests/repros/repro87-trace-overlap.test.tsx for updated typings.

Testing

  • Ran the unit test suite with bun test including tests/components/normal-components/chip-no-connect-prop.test.tsx and tests/repros/repro87-trace-overlap.test.tsx, and all tests passed.

Codex Task

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 17, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment Apr 17, 2026 3:48pm

Request Review

@seveibar seveibar merged commit e5a8a25 into main Apr 17, 2026
11 checks passed
@seveibar seveibar deleted the codex/add-support-for-noconnect-property branch April 17, 2026 18:12
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants