Add min via size support#2148
Closed
mohan-bee wants to merge 5 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
waiting for these PR's to merge |
Contributor
rushabhcodes
left a comment
rushabhcodes
left a comment
There was a problem hiding this comment.
needs seve's approval for this chanage
mohan-bee
changed the title
imrishabh18
requested changes
Apr 19, 2026
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
The names are confusing, minViaHole doesn't mean anything much.
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes minViaDiameter and minViaHole flow through core properly.
They now work from TSX on and , get stored in Circuit JSON/PCB data, pass into SimpleRouteJson, and are used when routed vias are created as pcb_via elements. It also removes the hardcoded 0.6 via size in phased autorouting so core uses the configured via size instead.