Add supplier_footprint_mismatch_warning when footprint string does not match with the jlcpcb footprint#2202
Merged
imrishabh18 merged 2 commits intomainfrom Apr 28, 2026
Merged
Conversation
…t match with the jlcpcb footprint
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
changed the title
supplier_footprint_mismatch_warning when footprint string does not match with the jlcpcb footprint
seveibar
reviewed
Apr 28, 2026
| doInitialSupplierFootprintMismatchWarning(): void { | ||
| NormalComponent_doInitialSupplierFootprintMismatchWarning( | ||
| this, | ||
| (name, effect) => this._queueAsyncEffect(name, effect), |
Contributor
There was a problem hiding this comment.
no second arguments for these methods
seveibar
reviewed
Apr 28, 2026
| "digikey", | ||
| "mouser", | ||
| "lcsc", | ||
| ] |
Contributor
There was a problem hiding this comment.
can you import this from props? Is this the best place to define this?
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.