Skip to content

chore: update calculate-packing dep#2213

Merged
MustafaMulla29 merged 4 commits intomainfrom
upd/cal
May 3, 2026
Merged

chore: update calculate-packing dep#2213
MustafaMulla29 merged 4 commits intomainfrom
upd/cal

Conversation

@MustafaMulla29
Copy link
Copy Markdown
Contributor

No description provided.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview, Comment May 3, 2026 7:34am

Request Review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an issue?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont know what is happening here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you repro this in calculate packing? I am almost positive some important logic was removed

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is probably a center obstacle created for pad only chip defs or something

@MustafaMulla29 MustafaMulla29 requested a review from seveibar May 1, 2026 15:20
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rp2040 zero is a bit broke. Please investigate

@MustafaMulla29
Copy link
Copy Markdown
Contributor Author

Screenshot 2026-05-01 at 9 31 24 PM @seveibar on tscircuit.com as well its packing inside it

@MustafaMulla29 MustafaMulla29 merged commit 47d530a into main May 3, 2026
10 checks passed
@MustafaMulla29 MustafaMulla29 deleted the upd/cal branch May 3, 2026 08:17
@tscircuitbot
Copy link
Copy Markdown
Contributor


Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants