Fix default nominal trace width for krt autorouter routes#2297
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
imrishabh18
reviewed
May 13, 2026
| const isSingleLayerBoard = this._getSubcircuitLayerCount() === 1 | ||
|
|
||
| const minTraceWidth = Number(props.minTraceWidth ?? 0.15) | ||
| const nominalTraceWidth = Number(props.nominalTraceWidth ?? 0.15) |
Contributor
There was a problem hiding this comment.
I think so! But we should import this frome somewhere maybe so that we have it encoded… is it jlcpcb recommended trace size or something?
Member
There was a problem hiding this comment.
jlcpcb capabilities page don't have anything as optimal size, it's just they have 0.10 as min trace width. So, I think 0.15 is okay
imrishabh18
approved these changes
May 13, 2026
Member
imrishabh18
left a comment
imrishabh18
left a comment
There was a problem hiding this comment.
Just confirm from Seve about the default value for this, or if there shouldn't be any default value
seveibar
approved these changes
May 13, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.