Use female CAD footprints for pinheader components with gender="female"#2330
Merged
rushabhcodes merged 2 commits intoMay 23, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
approved these changes
May 23, 2026
There was a problem hiding this comment.
Pull request overview
Fixes implied CAD footprint selection for <pinheader gender="female" /> so that the generated footprinter_string differentiates female headers from the default (male) variant, preventing incorrect CAD model reuse.
Changes:
- Update
PinHeader._getImpliedFootprintString()to append"_female"whengender === "female". - Add a regression test asserting
cad_component.footprinter_stringcontains"_female"for a female pinheader.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
lib/components/normal-components/PinHeader.ts |
Appends "_female" to the implied footprinter string when the pinheader gender is female. |
tests/components/normal-components/pin-header-female-cad-model.test.tsx |
Regression test ensuring female gender impacts the generated CAD footprinter string. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seveibar
approved these changes
May 23, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a core rendering bug where pinheader components with gender="female" did not propagate that gender into the implied CAD
footprint selection.
PinHeader now appends _female to the generated footprinter_string, so female headers resolve to the correct CAD model instead of
reusing the default male footprint.
Why this matters
This is a subtle but important core modeling/rendering fix:
Reproduction and test coverage
This PR includes a regression test that reproduces the issue and verifies the fix: