feat: pcb_keepout added#48
Merged
imrishabh18 merged 5 commits intomainfrom Sep 8, 2024
Merged
Conversation
4d6ab12 to
3afe8cf
Compare
Contributor
Size ReportBundle Size
Install Size
Full Howfat Output (PR Branch) |
seveibar
reviewed
Sep 6, 2024
seveibar
reviewed
Sep 6, 2024
seveibar
requested changes
Sep 6, 2024
Contributor
There was a problem hiding this comment.
looks good, but we should resolve the soup definition issues. IMO it is always worth having API repos like @tscircuit/soup and @tscircuit/props PRs reviewed because as soon as we realize something is wrong in the api design we generally shouldn't merge anything that uses the the deprecated api design (it gets really confusing to have old api versions/data hanging around- not worth it)
Member
Author
|
@seveibar For keepout the layer value can be both |
seveibar
approved these changes
Sep 7, 2024
bbb90a0 to
19b60fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview:
https://pcb-viewer-dahpoxxe0-tscircuit.vercel.app/?path=/story/keepout--keepout-rect-example