Skip to content

feat: pcb_keepout added#48

Merged
imrishabh18 merged 5 commits intomainfrom
feat/pcb_keepout
Sep 8, 2024
Merged

feat: pcb_keepout added#48
imrishabh18 merged 5 commits intomainfrom
feat/pcb_keepout

Conversation

@imrishabh18
Copy link
Copy Markdown
Member

@imrishabh18 imrishabh18 commented Sep 6, 2024

@tscircuitbot
Copy link
Copy Markdown
Contributor

tscircuitbot commented Sep 6, 2024

Size Report

Bundle Size

  • Base branch size: 292K
  • PR branch size: 300K
  • Difference: +8

Install Size

  • Base branch size: 5.18mb
  • PR branch size: 5.26mb
  • Difference: +.08

Full Howfat Output (PR Branch)

@tscircuit/core@0.0.44 (41 deps, 5.26mb, 660 files, ©undefined)
╭──────────────────────────────────────┬──────────────┬──────────┬───────┬───────────┬──────────────┬───────────╮
│ Name                                 │ Dependencies │     Size │ Files │ Native    │ License      │ Deprec    │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @lume/kiwi@0.4.3                     │              │ 121.45kb │    31 │           │ BSD-3-Clause │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/infgrid-ijump-astar@0.0.9 │              │ 114.74kb │    13 │           │              │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/props@0.0.62              │              │ 410.17kb │    28 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/soup-util@0.0.23          │           26 │   1.38mb │   234 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ @tscircuit/soup@0.0.67               │           24 │   1.11mb │   203 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ footprinter@0.0.44                   │           25 │   1.31mb │   214 │           │ ISC          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ react-reconciler@0.29.2              │            5 │   1.07mb │    56 │           │ MIT          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ react@18.3.1                         │            2 │ 331.04kb │    33 │           │ MIT          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ schematic-symbols@0.0.17             │              │ 133.62kb │    37 │           │              │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ transformation-matrix@2.16.1         │              │ 430.45kb │    56 │           │ MIT          │           │
├──────────────────────────────────────┼──────────────┼──────────┼───────┼───────────┼──────────────┼───────────┤
│ zod@3.23.8                           │              │ 651.16kb │    50 │           │ MIT          │           │
╰──────────────────────────────────────┴──────────────┴──────────┴───────┴───────────┴──────────────┴───────────╯

@imrishabh18 imrishabh18 requested a review from seveibar September 6, 2024 18:25
Comment thread lib/components/primitive-components/Keepout.ts Outdated
Comment thread lib/components/primitive-components/Keepout.ts
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we should resolve the soup definition issues. IMO it is always worth having API repos like @tscircuit/soup and @tscircuit/props PRs reviewed because as soon as we realize something is wrong in the api design we generally shouldn't merge anything that uses the the deprecated api design (it gets really confusing to have old api versions/data hanging around- not worth it)

@imrishabh18 imrishabh18 requested a review from seveibar September 6, 2024 20:19
@imrishabh18
Copy link
Copy Markdown
Member Author

@seveibar For keepout the layer value can be both top and bottom, right?

@imrishabh18 imrishabh18 merged commit 1cd0587 into main Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants