Skip to content

Automatically add net labels when a chip-to-chip trace#527

Merged
seveibar merged 2 commits intotscircuit:mainfrom
techmannih:chip
Jan 15, 2025
Merged

Automatically add net labels when a chip-to-chip trace#527
seveibar merged 2 commits intotscircuit:mainfrom
techmannih:chip

Conversation

@techmannih
Copy link
Copy Markdown
Member

@techmannih techmannih commented Jan 15, 2025

fixes #524
/claim #524

Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you simplify the test case (make it as simple as possible, just one trace!)

can you make sure your test has the correct behavior:

test with a bigger chip (8 pins) and a small chip (6 pins) and make sure that the net label uses the name of the bigger chip.

e.g. if U1 is the bigger chip, the net label should prefer to name itself after the big chip

thank you!!!

@techmannih
Copy link
Copy Markdown
Member Author

@seveibar all done

Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok cool.

if you want a new issue, im curious what would happen if you removed the pinlabels from one chip. It could break- which would be a great new issue!!

@techmannih
Copy link
Copy Markdown
Member Author

yeah sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatically add net labels when a chip-to-chip trace fails to route, use the name of the larger chip for the net label

2 participants