Automatically add net labels when a chip-to-chip trace#527
Merged
seveibar merged 2 commits intotscircuit:mainfrom Jan 15, 2025
techmannih:chip
Merged
Automatically add net labels when a chip-to-chip trace#527seveibar merged 2 commits intotscircuit:mainfrom techmannih:chip
seveibar merged 2 commits intotscircuit:mainfrom
techmannih:chip
Conversation
seveibar
requested changes
Jan 15, 2025
Contributor
seveibar
left a comment
There was a problem hiding this comment.
can you simplify the test case (make it as simple as possible, just one trace!)
can you make sure your test has the correct behavior:
test with a bigger chip (8 pins) and a small chip (6 pins) and make sure that the net label uses the name of the bigger chip.
e.g. if U1 is the bigger chip, the net label should prefer to name itself after the big chip
thank you!!!
Member
Author
|
@seveibar all done |
seveibar
approved these changes
Jan 15, 2025
Contributor
seveibar
left a comment
There was a problem hiding this comment.
Ok cool.
if you want a new issue, im curious what would happen if you removed the pinlabels from one chip. It could break- which would be a great new issue!!
Member
Author
|
yeah sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #524
/claim #524