Add source_failed_to_create_component_error to skip complete circuit render failure and add only the failed component to db#779
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
imrishabh18
changed the title
source_failed_to_create_component_error to skip complete circui…source_failed_to_create_component_error to skip complete circuit render failure and add only the failed component to db
| error_type: "source_failed_to_create_component_error", | ||
| }) | ||
| } | ||
| return createErrorPlaceholderComponent(type, props, error) |
There was a problem hiding this comment.
this is an interesting idea, why not have the placeholder component render the error? We could have it be a Renderable with props, that would allow inspection. It would render the error to circuit json
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
imrishabh18
force-pushed
the
add-source-failed-to-create-component
branch
from
e059495 to
e10bf6d
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
Most of the tests are failing because of position of the silkscreen text, 🤔
|
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
| component_name: this._parsedProps.component_name, | ||
| message: this._parsedProps.message, | ||
| pcb_center: this._parsedProps.pcb_center, | ||
| schematic_center: this._parsedProps.schematic_center, |
There was a problem hiding this comment.
it's ok to do this in the next PR, but you need to translate this by the parent group's position, you can look at schematic and pcb primitives to see how they do it
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
@imrishabh18 this is amazing, INCREDIBLE
…t render failure and add only the failed component to db
imrishabh18
force-pushed
the
add-source-failed-to-create-component
branch
from
9c5098e to
bec42ba
Compare
3 participants
/close tscircuit/tscircuit.com#990