implemented nine point title alignment for schematic box#891
Merged
seveibar merged 8 commits intotscircuit:mainfrom Jun 12, 2025
Abse2001:main
Merged
implemented nine point title alignment for schematic box#891seveibar merged 8 commits intotscircuit:mainfrom Abse2001:main
seveibar merged 8 commits intotscircuit:mainfrom
Abse2001:main
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seveibar
reviewed
Jun 8, 2025
seveibar
reviewed
Jun 8, 2025
seveibar
reviewed
Jun 8, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
very close, two remaining concerns
seveibar
reviewed
Jun 8, 2025
| const centerX = typeof props.schX === "number" ? props.schX : 0 | ||
| const centerY = typeof props.schY === "number" ? props.schY : 0 | ||
| centerX = typeof props.schX === "number" ? props.schX : 0 | ||
| centerY = typeof props.schY === "number" ? props.schY : 0 |
Contributor
There was a problem hiding this comment.
this is wrong and will fail if the box is within a schematic group- use this._getSchematicPositionBeforeLayout
seveibar
reviewed
Jun 8, 2025
seveibar
reviewed
Jun 8, 2025
lib/components/primitive-components/getTitleAnchorAndPosition.ts
Outdated
Show resolved
Hide resolved
seveibar
approved these changes
Jun 8, 2025
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
you can fix the issue inside of schematic groups in the next PR but you shouldn't redefine a NinePointAnchor enum
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
Contributor
Author
|
I will fix the issue inside of schematic groups in the next PR as you recommended |
seveibar
approved these changes
Jun 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.