Skip to content

Fix solderjumper internallyConnectedPins symbol bug#920

Merged
ShiboSoftwareDev merged 8 commits intomainfrom
codex/fix-bug-with-internallyconnectedpins-on-jumper
Jun 15, 2025
Merged

Fix solderjumper internallyConnectedPins symbol bug#920
ShiboSoftwareDev merged 8 commits intomainfrom
codex/fix-bug-with-internallyconnectedpins-on-jumper

Conversation

@ShiboSoftwareDev
Copy link
Contributor

@ShiboSoftwareDev ShiboSoftwareDev commented Jun 14, 2025

Summary

  • fix SolderJumper schematic symbol name derivation when pinCount is omitted
  • add repro test for using internallyConnectedPins on Jumper/SolderJumper

Testing

  • bun test

this was the error which now is fixed
image


https://chatgpt.com/codex/tasks/task_e_684d4b032b4883328c953439aabb8ce2

@vercel
Copy link

vercel bot commented Jun 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tscircuit-core-benchmarks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2025 3:59pm

Copy link
Member

@imrishabh18 imrishabh18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a snapshot as well of the schematic?

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confused, do you mean to be modifying the SolderJumper.ts file? The Jumper should not use schematic symbols

@ShiboSoftwareDev ShiboSoftwareDev merged commit 31ac0fe into main Jun 15, 2025
10 checks passed
@ShiboSoftwareDev ShiboSoftwareDev deleted the codex/fix-bug-with-internallyconnectedpins-on-jumper branch June 15, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants