Skip to content

Conversation

@seveibar
Copy link
Contributor

@seveibar seveibar commented Nov 6, 2025

Summary

  • rewrite the measuring circuit size guide to focus on board template selection and remove Adom-specific wording
  • document JSON metadata imports and add a metadata-driven carrier example
  • embed a CircuitPreview that loads metadata via fsMap to demonstrate template selection

Testing

  • bunx tsc --noEmit (fails: repository lacks local Docusaurus/React dependencies and JSX settings in this environment)
  • bun run format (fails: biome CLI is not installed in the container)

https://chatgpt.com/codex/tasks/task_b_690ce38d6a90832e90e3221be76e2996

@vercel
Copy link

vercel bot commented Nov 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 7, 2025 7:16am

@seveibar seveibar marked this pull request as ready for review November 7, 2025 07:16
@seveibar seveibar changed the title Rewrite circuit size guide with preview example First tscircuit scripting guide, how to programmatically get the circuit size Nov 7, 2025
@seveibar seveibar merged commit aec706a into main Nov 7, 2025
5 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +73 to +78
for (const file of await Bun.glob("design-groups/*.tsx")) {
const { default: GroupComponent } = await import(`../${file}`);
const groupName = file.split("/").pop()?.replace(".tsx", "");
const circuit = new RootCircuit();
circuit.add(<GroupComponent />);
await circuit.renderUntilSettled();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use matching export type when glob-loading groups

The globbed loading example destructures default from each module, but the doc’s preceding snippet defines groups as named exports (export const Esp32Breakout ...). For files that follow the named-export guidance, GroupComponent becomes undefined and the call to circuit.add(<GroupComponent />) throws. Either import a named export or update the recommended group files to export a default component.

Useful? React with 👍 / 👎.

@seveibar
Copy link
Contributor Author

seveibar commented Nov 7, 2025

CC @Ayushjhawar8 the sidebar styling for this new page looks a bit weird

@tscircuitbot
Copy link


Thank you for your contribution! 🎉

PR Rating:
Impact: Tiny

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants