Skip to content

Fix group board wrapper issue#751

Merged
imrishabh18 merged 1 commit intomainfrom
codex/fix-circuit-json-to-have-one-source_group
Jul 28, 2025
Merged

Fix group board wrapper issue#751
imrishabh18 merged 1 commit intomainfrom
codex/fix-circuit-json-to-have-one-source_group

Conversation

@imrishabh18
Copy link
Copy Markdown
Member

Summary

  • avoid auto adding a board wrapper when the main component already contains a <group>
  • add regression test to ensure only a single source_group is created

Testing

  • bun test tests/group-wrapper.test.tsx
  • bun test tests (fails: example14 runTscircuitModule, NineKeyKeyboard default export resolves and renders correctly, circuit-web-worker-events, example16-jlc-parts-engine with entrypoint, example16-jlc-parts-engine with mainComponentPath, example15 runTscircuitModule with props, virtual filesystem with components, example4-root-child-issue, parse tscircuit.config.js with mainEntrypoint, kill method > should immediately terminate the worker, example9-not-defined-component, circuitrunner1-readme-example)

https://chatgpt.com/codex/tasks/task_b_6885ae74aaf08327a6ec6569a29e8324

@imrishabh18 imrishabh18 merged commit cc5cab0 into main Jul 28, 2025
4 checks passed
@imrishabh18 imrishabh18 deleted the codex/fix-circuit-json-to-have-one-source_group branch July 28, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants