Skip to content

introduced solderjumper footprint#255

Merged
seveibar merged 4 commits intotscircuit:mainfrom
ShiboSoftwareDev:main
May 8, 2025
Merged

introduced solderjumper footprint#255
seveibar merged 4 commits intotscircuit:mainfrom
ShiboSoftwareDev:main

Conversation

@ShiboSoftwareDev
Copy link
Copy Markdown
Contributor

@ShiboSoftwareDev ShiboSoftwareDev commented May 7, 2025

there is no way to know the pins and connect them using source traces, so I used pcb traces

maybe we keep them disconnected and connect them in core once we know the port ids of the pads?

Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is OK but the smtpad size is super arbitrary, most jumpers i would assume are plated holes. I might call this jumperpads and have the standard pw (pad width) and ph (pad height) as parameters

looking good though

Comment thread src/fn/jumper.ts
@ShiboSoftwareDev
Copy link
Copy Markdown
Contributor Author

@seveibar can I call it solderjumper?
image

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented May 8, 2025

@ShiboSoftwareDev hmm solderjumper_bridged and solderjumper_bridged(1,2)

@seveibar
Copy link
Copy Markdown
Contributor

seveibar commented May 8, 2025

@ShiboSoftwareDev sgtm!

@ShiboSoftwareDev
Copy link
Copy Markdown
Contributor Author

@seveibar solderjumper_bridged23 and solderjumper_bridged123 sound better

Comment thread src/footprinter.ts Outdated
@ShiboSoftwareDev ShiboSoftwareDev requested a review from seveibar May 8, 2025 13:17
@ShiboSoftwareDev ShiboSoftwareDev changed the title introduced jumper footprint introduced solderjumper footprint May 8, 2025
@seveibar seveibar merged commit 007ed80 into tscircuit:main May 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants