Skip to content

add support potentiometer_ca14_h5#262

Merged
techmannih merged 12 commits intotscircuit:mainfrom
techmannih:Potentiometer
May 12, 2025
Merged

add support potentiometer_ca14_h5#262
techmannih merged 12 commits intotscircuit:mainfrom
techmannih:Potentiometer

Conversation

@techmannih
Copy link
Copy Markdown
Member

fix #261
/claim #261

Comment thread src/fn/potentiometer.ts
Comment thread src/fn/potentiometer.ts
Comment thread src/fn/potentiometer.ts Outdated
Comment thread tests/potentiometer.test.ts Outdated
Comment thread src/fn/potentiometer.ts
Comment thread src/fn/potentiometer.ts Outdated
Comment thread src/fn/potentiometer.ts Outdated
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i understand the caliper axis dimension but not the acp

@techmannih techmannih changed the title add support potentiometer_ca14_h5 add support potentiometer_acp_ca14_h5 May 10, 2025
@techmannih
Copy link
Copy Markdown
Member Author

techmannih commented May 10, 2025

@seveibar

Screenshot_20250510_190101_Google

@seveibar
Copy link
Copy Markdown
Contributor

@techmannih i dont think we're going to do any company-specific footprints, so you should remove that.

@seveibar
Copy link
Copy Markdown
Contributor

You could use "ca" to detect if we should use caliper distance

Comment thread src/fn/potentiometer.ts
@techmannih techmannih changed the title add support potentiometer_acp_ca14_h5 add support potentiometer_ca14_h5 May 10, 2025
Copy link
Copy Markdown
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving note

Comment thread src/fn/potentiometer.ts Outdated
Comment thread src/fn/potentiometer.ts
Comment thread src/fn/potentiometer.ts
Comment thread src/footprinter.ts Outdated
Comment thread tests/potentiometer.test.ts
Comment thread src/fn/potentiometer.ts
@techmannih techmannih marked this pull request as draft May 12, 2025 04:13
@techmannih techmannih marked this pull request as ready for review May 12, 2025 19:20
@techmannih techmannih merged commit d6eadb0 into tscircuit:main May 12, 2025
5 checks passed
@techmannih techmannih deleted the Potentiometer branch July 10, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support Potentiometer_ACP_CA14-H4 footprint

2 participants